fix(studio): retire legacy Style and Grade sections from flat inspector#2126
fix(studio): retire legacy Style and Grade sections from flat inspector#2126vanceingalls wants to merge 1 commit into
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
miga-heygen
left a comment
miga-heygen
left a comment
There was a problem hiding this comment.
Reviewed as part of the 15-PR edit-panel redesign stack. Full stack review posted on #2120. No blockers on this PR. — Miga
The flat inspector rendered its new Style/Grade groups AND the legacy ColorGradingSection/StyleSections components a second time below them, visibly doubling every control. Remove the now-redundant legacy render call sites (and their now-unused imports) from PropertyPanelFlat.tsx; those components stay intact for the legacy (flag-off) PropertyPanel.
miguel-heygen
left a comment
miguel-heygen
left a comment
There was a problem hiding this comment.
Final current-head pass: cabe45e. Reviewed the stack boundaries and current diff against the flat-inspector contracts; required checks have no failures/pending checks and no unresolved review threads remain. No new drift found; residual notes are non-blocking.
vanceingalls
force-pushed
the
studio-flat-07-retire-legacy-style-grade
branch
from
cabe45e to
40487ac
Compare
vanceingalls
force-pushed
the
studio-flat-06-pinning-multifield
branch
from
f3389dc to
45a06a5
Compare
miguel-heygen
left a comment
miguel-heygen
left a comment
There was a problem hiding this comment.
Superseding earlier approval: the latest max-review pass found confirmed correctness issues in this flat-inspector stack (identity/selector-index state, hide-all write races, timing inference, slider pointer/keyboard/reset semantics, and duplicate React keys). Hold merge and require fixes plus re-review on the current stack head.
3 participants
What
Seventh PR in the flat inspector stack (see #2120 for the foundation and full stack list). Removes the legacy
ColorGradingSection/StyleSectionsrender call sites fromPropertyPanelFlat.tsx— with the flag on, these were rendering a second time below their flat equivalents (Color grading, Radius, Stroke, Effects, Clip, Transparency, Fill all doubled).Stack: #2120 → #2121 → #2122 → #2123 → #2124 → #2125 → #2126 (this).
Why
This was flagged as an Important (non-blocking) finding in the final whole-branch review, then confirmed live during manual testing of #2125 — every Style/Grade control was visibly duplicated. Flat coverage was already confirmed complete for both groups, so the legacy twins were pure redundant duplication, not a fallback for missing functionality.
How
<ColorGradingSection>and<StyleSections hideFlex>blocks (and their now-dead imports) fromPropertyPanelFlat.tsxonly.propertyPanelColorGradingSection.tsx,propertyPanelStyleSections.tsx) are untouched — the non-flat legacyPropertyPanel.tsxstill uses them when the feature flag is off.useColorGradingControllernow runs exactly once per render instead of twice (the second invocation was inside the now-removed legacyColorGradingSectioninstance) — resolving another Important finding from the whole-branch review.Test plan
data-panel-sectionattribute) is absent with the flag on, scoped carefully to avoid a false failure against the flat Style group's own "Fill" row label (which is supposed to still render).oxlint/oxfmt/fallowclean.